Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove python .whl package dependency to swsssdk #265

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Remove python .whl package dependency to swsssdk #265

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10d6c3e
Remove dependency to swsssdk
Jul 18, 2022
8510126
Add test dependency
Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from setuptools import setup, find_packages

dependencies = [
'swsssdk>=2.0.1',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need remove this line to remove .whl package dependency to swsssdk package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_deps = [

Do you need add swsssdk into test_deps?

Refers to: setup.py:8 in 10d6c3e. [](commit_id = 10d6c3e, deletion_comment = False)

Will check if add to test_deps can pass build image.

'psutil>=4.0',
'python_arptable>=0.0.1',
]
Expand All @@ -10,10 +9,10 @@
'mockredispy>=2.9.3',
'pytest',
'pytest-cov',
'swsssdk>=2.0.1',
]

high_performance_deps = [
'swsssdk[high_perf]>=2.0.1',
]

setup(
Expand Down