Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[swss]: Allow portsyncd to run on system without ports #1808

Merged
merged 1 commit into from
Jul 17, 2021

Conversation

liorghub
Copy link
Contributor

What I did
Remove Portsyncd error exit if there are no ports in config DB.

Why I did it
Allow system with no ports in config db run without errors
This is needed for modular system which should boot properly without line cards.

How I verified it
Remove ports from config DB and verify proper init flow.

Details if related

@liorghub liorghub requested a review from prsunny as a code owner June 28, 2021 13:14
@liorghub liorghub changed the title Zero ports 2 [swss]: Allow portsyncd to run on system without ports Jun 28, 2021
@liorghub liorghub force-pushed the zero_ports_2 branch 2 times, most recently from bd742b1 to 1a0ad57 Compare July 2, 2021 16:17
Signed-off-by: liora <liora@nvidia.com>
@akokhan
Copy link
Contributor

akokhan commented Jul 15, 2021

I believe this can be also useful to be able to start with an empty configuration:
https://github.com/Azure/sonic-buildimage/blob/24c90cedc42fe8f133389248d5363e500fe04c0e/src/sonic-config-engine/config_samples.py#L154

@prsunny prsunny merged commit 9f0bb8d into sonic-net:master Jul 17, 2021
vaibhavhd added a commit to sonic-net/sonic-buildimage that referenced this pull request Aug 3, 2021
Update sonic-swss submodule head to include below fixes:

Ignore ALREADY_EXIST error in FDB creation (sonic-net/sonic-swss#1815)
Update MACsec SA PN counter to support SAI API 1.8 (sonic-net/sonic-swss#1818)
[swss]: Allow portsyncd to run on system without ports (sonic-net/sonic-swss#1808)
[debugcounterorch] check if counter type is supported before querying… (sonic-net/sonic-swss#1789)
[configure.ac] Add the option of passing libnl path to configure script (sonic-net/sonic-swss#1824)
refactor(fdbsyncd): Convert files with dos2unix (sonic-net/sonic-swss#1828)
[VS] Fix for VS test failures (sonic-net/sonic-swss#1836)
Td2: Reclaim buffer from unused ports (sonic-net/sonic-swss#1830)
[gearbox] Set context for phys based on configs (sonic-net/sonic-swss#1826)
[Dynamic Buffer Calc] Bug fix: Don't create lossless buffer profile for active ports without speed configured (sonic-net/sonic-swss#1822)
Bridge mac setting, fix statedb time format (sonic-net/sonic-swss#1844)
[cfgmgr]: Introduce common libs. (sonic-net/sonic-swss#1842)
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
…t#8313)

Update sonic-swss submodule head to include below fixes:

Ignore ALREADY_EXIST error in FDB creation (sonic-net/sonic-swss#1815)
Update MACsec SA PN counter to support SAI API 1.8 (sonic-net/sonic-swss#1818)
[swss]: Allow portsyncd to run on system without ports (sonic-net/sonic-swss#1808)
[debugcounterorch] check if counter type is supported before querying… (sonic-net/sonic-swss#1789)
[configure.ac] Add the option of passing libnl path to configure script (sonic-net/sonic-swss#1824)
refactor(fdbsyncd): Convert files with dos2unix (sonic-net/sonic-swss#1828)
[VS] Fix for VS test failures (sonic-net/sonic-swss#1836)
Td2: Reclaim buffer from unused ports (sonic-net/sonic-swss#1830)
[gearbox] Set context for phys based on configs (sonic-net/sonic-swss#1826)
[Dynamic Buffer Calc] Bug fix: Don't create lossless buffer profile for active ports without speed configured (sonic-net/sonic-swss#1822)
Bridge mac setting, fix statedb time format (sonic-net/sonic-swss#1844)
[cfgmgr]: Introduce common libs. (sonic-net/sonic-swss#1842)
@prsunny
Copy link
Collaborator

prsunny commented Aug 11, 2021

Looks like this PR is required for init flow - #1861. @liorghub , just curios on how you verified this change?

raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-swss that referenced this pull request Oct 5, 2021
Remove Portsyncd error exit if there are no ports in config DB.

Signed-off-by: liora <liora@nvidia.com>
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
Signed-off-by: Kebo Liu <kebol@nvidia.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants