[202211][ppi]: Implement port bulk comparison logic (#2564) #2821
Conversation
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@saiarcot895 as this is backport for a PR you approved on master, can you please review this as well? |
|
/azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -12,6 +12,9 @@ | |||
| #include "pfcactionhandler.h" | |||
| #include <sys/mman.h> | |||
| #undef private | |||
| #define private public | |||
| #include "warm_restart.h" | |||
| #undef private | |||
There was a problem hiding this comment.
Rather than doing this hack, can friendship declarations be used instead?
…late. (#2843) **What I did** * Increase robustness of `CodeQL`: use only dependencies with the relevant versions **Why I did it** * To fix `CodeQL` compilation failures **How I verified it** 1. Make a PR 2. Do a push **Details if related** * Backport from `master`: #2845 * Resolves checker issue: #2821 * Takes effect only after PR is merged
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
|
/azpw run |
|
/AzurePipelines run |
|
No commit pushedDate could be found for PR 2821 in repo sonic-net/sonic-swss |
|
/azpw run |
|
/AzurePipelines run |
|
No commit pushedDate could be found for PR 2821 in repo sonic-net/sonic-swss |
There was a problem hiding this comment.
LGTM.
@nazariig @liat-grozovik please attach the test results for the manual test done to verify AN/LT,FEC, port breakout
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run EasyCLA |
|
No commit pushedDate could be found for PR 2821 in repo sonic-net/sonic-swss |
liat-grozovik
changed the title
DEPENDS: [202211][ppi]: Implement port bulk comparison logic (#2564) #2821 HLD: sonic-net/SONiC#1084 What I did Removed unused code Why I did it To complete code cleanup How I verified it UT tests VS tests Details if related Backport from master: [ppi]: General code cleanup: remove unused methods #2867
Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com
DEPENDS:
HLD: sonic-net/SONiC#1084
What I did
Why I did it
How I verified it
Details if related
master: [ppi]: Implement port bulk comparison logic #2564