Use SonicV2Connector/ConfigDBConnector/SonicDBConfig from swsscommon instread of swsssdk #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging f7c3db6 into a50b7a2 - view on LGTM.com new alerts:
|
qiluo-msft
requested review from
jleveque,
neethajohn and
arlakshm
and removed request for
jleveque
jleveque
approved these changes
Feb 1, 2021
qiluo-msft
added a commit
that referenced
this pull request
Feb 8, 2021
…1409) **- What I did** Fixes sonic-net/sonic-buildimage#6708 This bug is exposed by #1392. Previously the `config` command will call `SonicDBConfig.load_sonic_global_db_config()` even on a single ASIC platform, and it will silently failed. After exposed, it will fail with error syslog message: ``` admin@sonic:~$ sudo config save Existing files will be overwritten, continue? [y/N]: ^CAborted! Feb 8 03:23:48.729434 sonic ERR sniffer: :- initializeGlobalConfig: Sonic database config global file doesn't exist at /var/run/redis/sonic-db/database_global.json ``` **- How to verify it** Tested on DUT
qiluo-msft
added a commit
that referenced
this pull request
Feb 11, 2021
…ontinued) (#1417) **- What I did** This bug is exposed by #1392. Previously the `config` command will call `SonicDBConfig.load_sonic_global_db_config()` even on a single ASIC platform, and it will silently failed. After exposed, it will fail with error syslog message: ``` Feb 9 05:04:46.462361 vlab-01 ERR python3: :- initializeGlobalConfig: Sonic database config global file doesn't exist at /var/run/redis/sonic-db/database_global.json ``` **- How to verify it** Unit test and test in DUT.
anand-kumar-subramanian
pushed a commit
to anand-kumar-subramanian/sonic-utilities
that referenced
this pull request
Mar 2, 2021
…instread of swsssdk (sonic-net#1392) - What I did Use SonicV2Connector/ConfigDBConnector/SonicDBConfig from swsscommon instread of swsssdk - How to verify it Unit test and test impacted command lines on DUT.
anand-kumar-subramanian
pushed a commit
to anand-kumar-subramanian/sonic-utilities
that referenced
this pull request
Mar 2, 2021
…onic-net#1409) **- What I did** Fixes sonic-net/sonic-buildimage#6708 This bug is exposed by sonic-net#1392. Previously the `config` command will call `SonicDBConfig.load_sonic_global_db_config()` even on a single ASIC platform, and it will silently failed. After exposed, it will fail with error syslog message: ``` admin@sonic:~$ sudo config save Existing files will be overwritten, continue? [y/N]: ^CAborted! Feb 8 03:23:48.729434 sonic ERR sniffer: :- initializeGlobalConfig: Sonic database config global file doesn't exist at /var/run/redis/sonic-db/database_global.json ``` **- How to verify it** Tested on DUT
anand-kumar-subramanian
pushed a commit
to anand-kumar-subramanian/sonic-utilities
that referenced
this pull request
Mar 2, 2021
…ontinued) (sonic-net#1417) **- What I did** This bug is exposed by sonic-net#1392. Previously the `config` command will call `SonicDBConfig.load_sonic_global_db_config()` even on a single ASIC platform, and it will silently failed. After exposed, it will fail with error syslog message: ``` Feb 9 05:04:46.462361 vlab-01 ERR python3: :- initializeGlobalConfig: Sonic database config global file doesn't exist at /var/run/redis/sonic-db/database_global.json ``` **- How to verify it** Unit test and test in DUT.
qiluo-msft
pushed a commit
that referenced
this pull request
Apr 5, 2021
yxieca
pushed a commit
that referenced
this pull request
Apr 8, 2021
liat-grozovik
pushed a commit
that referenced
this pull request
Apr 13, 2021
)" (#1561) - What I did It seems like this change is not backported to 202012: #1392 So this PR #1546 Is not required on 202012 branch. It was cherry-picked to 202012 and now the fast-reboot-dump script is broken. - How I did it Revert the commit. - How to verify it Run fast-reboot on 202012 branch.
gitsabari
pushed a commit
to gitsabari/sonic-utilities
that referenced
this pull request
Jun 15, 2021
…1546) #### What I did This PR sonic-net#1393 merged after PR: sonic-net#1392 This caused the first PR to be not aligned with SonicV2Connector change. This PR motivation is to fix it.
qiluo-msft
added a commit
that referenced
this pull request
Aug 25, 2021
This is a partial backport of #1392 Only add new mock support in unit test.
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this pull request
Aug 3, 2023
…1409) **- What I did** Fixes sonic-net/sonic-buildimage#6708 This bug is exposed by sonic-net/sonic-utilities#1392. Previously the `config` command will call `SonicDBConfig.load_sonic_global_db_config()` even on a single ASIC platform, and it will silently failed. After exposed, it will fail with error syslog message: ``` admin@sonic:~$ sudo config save Existing files will be overwritten, continue? [y/N]: ^CAborted! Feb 8 03:23:48.729434 sonic ERR sniffer: :- initializeGlobalConfig: Sonic database config global file doesn't exist at /var/run/redis/sonic-db/database_global.json ``` **- How to verify it** Tested on DUT
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this pull request
Aug 3, 2023
…ontinued) (#1417) **- What I did** This bug is exposed by sonic-net/sonic-utilities#1392. Previously the `config` command will call `SonicDBConfig.load_sonic_global_db_config()` even on a single ASIC platform, and it will silently failed. After exposed, it will fail with error syslog message: ``` Feb 9 05:04:46.462361 vlab-01 ERR python3: :- initializeGlobalConfig: Sonic database config global file doesn't exist at /var/run/redis/sonic-db/database_global.json ``` **- How to verify it** Unit test and test in DUT.
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this pull request
Aug 3, 2023
#### What I did This PR sonic-net/sonic-utilities#1393 merged after PR: sonic-net/sonic-utilities#1392 This caused the first PR to be not aligned with SonicV2Connector change. This PR motivation is to fix it.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Use SonicV2Connector/ConfigDBConnector/SonicDBConfig from swsscommon instread of swsssdk
- How I did it
- How to verify it
Unit test and test impacted command lines on DUT.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)