Remove suppress-fib-pending CLI and make route_check.py check suppress-fib in BGP configuration #3331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepanblyschak
force-pushed
the
revert-suppress-fib
branch
2 times, most recently
from
50eb155 to
f9c5c38
Compare
stepanblyschak
force-pushed
the
revert-suppress-fib
branch
from
f9c5c38 to
772f3de
Compare
…onic-net#2495)" This reverts commit 9126e7f.
stepanblyschak
force-pushed
the
revert-suppress-fib
branch
from
772f3de to
d622580
Compare
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
stepanblyschak
force-pushed
the
revert-suppress-fib
branch
from
d622580 to
9f5d67c
Compare
stepanblyschak
changed the title
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
abdosi
previously approved these changes
Jun 25, 2024
|
@stepanblyschak : Please help resolveconflict. @anamehra for viz. |
anamehra
approved these changes
Jun 25, 2024
arlakshm
approved these changes
Jul 1, 2024
yejianquan
pushed a commit
to yejianquan/sonic-utilities
that referenced
this pull request
Jul 1, 2024
…s-fib in BGP configuration (sonic-net#3331) What I did Revert suppress FIB pending feature Why I did it Some unresolved FRR issues in current version How I verified it Build and run [route_check] check if suppress fib is enabled in bgp Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
yejianquan
pushed a commit
to yejianquan/sonic-utilities
that referenced
this pull request
Jul 1, 2024
…s-fib in BGP configuration (sonic-net#3331) What I did Revert suppress FIB pending feature Why I did it Some unresolved FRR issues in current version How I verified it Build and run [route_check] check if suppress fib is enabled in bgp Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
yejianquan
added a commit
that referenced
this pull request
Jul 12, 2024
…s-fib in BGP configuration (#3331) (#3391) What I did Cherry-pick #3331 to 202405 and resolve conflicts Revert suppress FIB pending feature Why I did it Some unresolved FRR issues in current version How I verified it Build and run [route_check] check if suppress fib is enabled in bgp Signed-off-by: Stepan Blyschak <stepanb@nvidia.com> Co-authored-by: Stepan Blyshchak <38952541+stepanblyschak@users.noreply.github.com> co-authorized by: jianquanye@microsoft.com
StormLiangMS
pushed a commit
that referenced
this pull request
Sep 2, 2024
… suppress-fib in BGP configuration" (#3477) Reverts #3331 BGP zebra enhancements is merged to master branch sonic-net/sonic-buildimage#19717 Reverting the revert of bgp suppress pending feature to enable it in master branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Revert suppress FIB pending feature
Why I did it
Some unresolved FRR issues in current version
How I verified it
Build and run
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)