[config] Don't attempt to restart disabled services #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 12, 2020
lguohan
approved these changes
Jun 12, 2020
abdosi
pushed a commit
that referenced
this pull request
Jun 16, 2020
When restarting services, don't attempt to restart a service if it is disabled/masked or the `systemctl restart` command will fail, causing the calling command (e.g., `config load`, `config reload`, `config load_minigraph`) to error out.
jleveque
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jun 20, 2020
- Ensure all features (services) are in the configured state when hostcfgd starts - Better functionalization of code - Also replace calls to deprecated `has_key()` method in `tacacs_server_handler()` and `tacacs_global_handler()` with `in` keyword. This PR depends on sonic-net/sonic-utilities#944, otherwise `config load_minigraph` will fail when trying to restart disabled services.
jleveque
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jun 24, 2020
When building the SONiC image, used systemd to mask all services which are set to "disabled" in init_cfg.json. This PR depends on sonic-net/sonic-utilities#944, otherwise `config load_minigraph will fail when trying to restart disabled services.
abdosi
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jun 28, 2020
- Ensure all features (services) are in the configured state when hostcfgd starts - Better functionalization of code - Also replace calls to deprecated `has_key()` method in `tacacs_server_handler()` and `tacacs_global_handler()` with `in` keyword. This PR depends on sonic-net/sonic-utilities#944, otherwise `config load_minigraph` will fail when trying to restart disabled services.
abdosi
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jun 28, 2020
When building the SONiC image, used systemd to mask all services which are set to "disabled" in init_cfg.json. This PR depends on sonic-net/sonic-utilities#944, otherwise `config load_minigraph will fail when trying to restart disabled services.
abdosi
pushed a commit
to abdosi/sonic-utilities
that referenced
this pull request
Aug 4, 2020
When restarting services, don't attempt to restart a service if it is disabled/masked or the `systemctl restart` command will fail, causing the calling command (e.g., `config load`, `config reload`, `config load_minigraph`) to error out.
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
[201911][thermal control] Backport changes from master branch (sonic-net#929) [201911][config] Support abbreviation (sonic-net#933) Add 'hw-management-generate-dump.sh' to 'show techsupport' command (sonic-net#934) [fwutil]: Update fwutil to v2.0.0.0. (sonic-net#942) Fixes bug for PFCWD feature parameters (sonic-net#838) Fixed fast-reboot for BFN platform (sonic-net#871) [config] Add 'interface transceiver' subgroup with 'lpmode' and 'reset' subcommands (sonic-net#904) [warm-reboot]: added pre-check for ISSU file (sonic-net#915) [config] Don't attempt to restart disabled services (sonic-net#944)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When restarting services, don't attempt to restart a service if it is disabled/masked or the
systemctl restartcommand will fail, causing the calling command (e.g.,config load,config reload,config load_minigraph) to error out.