Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix iOS 9.3 #143

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Fix iOS 9.3 #143

merged 1 commit into from
Jan 25, 2022

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Jan 11, 2022

This was originally found in 5664422, I've just uncommented it because it made my setup work:

  • Device: iPad mini 1st generation, running iOS 9.3.6
  • Host: macOS 10.14.6 Mojave

@kali
Copy link
Collaborator

kali commented Jan 24, 2022

It does look pretty harmless, not sure why it has been commented out. The debug message is a bit noisy, so I guess we could remove it.

As soon as I will have merged #146 and #145 , could you rebase this branch on the new main ?

@madsmtm madsmtm force-pushed the fix-active-session branch from 55e919c to 1aaccda Compare January 24, 2022 17:49
@madsmtm
Fix iOS 9.3 (maybe)
a347f4c 
This was found in 5664422, I've just uncommented it
@madsmtm madsmtm force-pushed the fix-active-session branch from 1aaccda to a347f4c Compare January 24, 2022 17:50
@madsmtm
Copy link
Contributor Author

madsmtm commented Jan 24, 2022

Done, thanks for taking the time for this!

@kali kali merged commit 83b6264 into sonos:main Jan 25, 2022
@madsmtm madsmtm deleted the fix-active-session branch April 17, 2024 04:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsmtm @kali