Initial stuff for aarch64 ios simulator support #151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #147.
I don't think we can test this in CI. I've tested it on my m1 and it works as expected.
This change results in
cargo dinghy all-devices
shows:Though, on non-m1 apple products it will still display
auto-ios-aarch64-sim
and if ran, I assume it would fail with a weird error but I've not tested that. Should I make non aarch64 devices not list theauto-ios-aarch64-sim
?As a note why this is useful I tested this with
hyperfine
in thetest-ws
CI (that's pre-compiled):In this case, I think this ~2 second difference might be due to macOS or the iOS simulator starting Rosetta 2 to run the x86 program but being able to test and benchmark on the architecture a program is running is important.