try to make the excluded bug appear in CI #159
Conversation
| $ANDROID_SDK_ROOT/cmdline-tools/latest/bin/sdkmanager --install "system-images;android-24;default;armeabi-v7a" "ndk;22.1.7171670" | ||
| echo no | $ANDROID_SDK_ROOT/cmdline-tools/latest/bin/avdmanager create avd -n testdinghy -k "system-images;android-24;default;armeabi-v7a" | ||
| $ANDROID_SDK_ROOT/emulator/emulator @testdinghy -no-audio -no-boot-anim -no-window -accel on -gpu off & | ||
| timeout 180 $ANDROID_SDK_ROOT/platform-tools/adb wait-for-device |
There was a problem hiding this comment.
Thoughts on using a github action for this? ReactiveCircus/android-emulator-runner looks like it might do the trick.
There was a problem hiding this comment.
the problem with this github action is that it only works on macos runners, I wanted to have something that was able to test android on linux ^^ plus having those 4 lines here in the script means it is a bit easier to replicate when testing locally
There was a problem hiding this comment.
Hope you don't mind me doing a drive by review.
Anyway, given how much this is modifying .travis.sh, it might make sense to break the script into two or three scripts. Something like .github/ios.sh and .github/android.sh and .github/host.sh where the host.sh would be running dinghy on the host machines.
Admittedly, it seems that this PR is to fix some bug that's appearing outside CI.
fredszaq
force-pushed
the
fix-excluded-tests
branch
3 times, most recently
from
7e6d109 to
ad8c185
Compare
fredszaq
force-pushed
the
fix-excluded-tests
branch
from
ad8c185 to
8a9ec62
Compare
|
This PR fixes the few problems we have found when migrating the tract ci to the new version
The ci script could indeed be split by device, especially as we should add tests for the ssh device which is not tested in the ci right now (we can probably come up with something using docker) not sure we'll do that in this pr, as the goal here is to fix the broken 0.5.0 release |
No description provided.