Universal macos binary in CI #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simlay
commented
Feb 21, 2024
| @@ -32,11 +32,14 @@ jobs: | |||
| mkdir $ZIPDIR | |||
| if [ ${{matrix.name}} == "macos" ] | |||
| then | |||
| # Let's ensure that both aarch64 and x86_64 targets are installed | |||
| rustup target add aarch64-apple-darwin x86_64-apple-darwin | |||
There was a problem hiding this comment.
I don't love that only one of these two targets is definitely already installed but in the future this will be on an m1 so the x86_64 target will need to be installed.
kali
approved these changes
Feb 21, 2024
Merged
briansmith
added a commit
to briansmith/getrandom
that referenced
this pull request
Jun 20, 2024
There is now a universal binary after sonos/dinghy#209.
briansmith
added a commit
to briansmith/getrandom
that referenced
this pull request
Jun 20, 2024
There is now a universal binary after sonos/dinghy#209.
newpavlov
pushed a commit
to rust-random/getrandom
that referenced
this pull request
Jun 21, 2024
There is now a universal binary after sonos/dinghy#209.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #200.
Similar work to
cargo-binstall.