Fix multiple versions of the same dynamic lib used #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kali
approved these changes
Feb 25, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in the Android NDK r19b, there are multiple versions of the same library for different architectures. Dinghy would find the correct lib file first, but then would search for more lib files and find the files for incorrect architectures. It led to some strange behaviors where Dinghy would try to run a 64 bit ARM binary with a 32 bit Intel dynamic library.
This fix applies a filter on the library file path list by taking the first occurrence of a library file and discard the rest of the occurrences. Therefore, there is only one version of each lib in the list, most likely the fitting one.