Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make automatic platform decision for a given device deterministic #84

Merged
merged 3 commits into from
Feb 27, 2019

Conversation

Deluvi
Copy link
Contributor

@Deluvi Deluvi commented Feb 26, 2019

Previously, running the -d argument for an android device without explicitly defining the platform would randomly take a platform with the fitting architecture but with a certain API level which was a semi-random choice of all available API levels.

Now, the choice will be to take the default API level of the device architecture, which is currently pointing to API level 21 for all architectures. The user can still specify a particular API using the --platform argument which works with -d.

@Deluvi Deluvi self-assigned this Feb 26, 2019
@Deluvi Deluvi requested a review from kali February 26, 2019 15:24
Copy link
Collaborator

@kali kali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small style issue, I would prefer the helper function to be closer to where it's called, as it is unlikely we will use it anywhere else. If we leave it there, it is likely to drift away from where it is used and it could get confusing: this is one instance where the function body itself is roughly two lines and is more descriptive than the function name...

So, we can shove it in the function body, just before the devices.into_iter() or... inline it as a closure.

@kali kali merged commit 0818728 into master Feb 27, 2019
@kali kali deleted the android-ndk-19+-auto-platform-select branch February 27, 2019 08:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants