Added --log-level argument #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgotti
requested changes
Jul 4, 2017
There was a problem hiding this comment.
@albertvaka thanks for the PR, can you please rebase and squash in an unique commit? Looks like semaphore, for whatever reason didn't run the build for this PR...
cmd/keeper/keeper.go
Outdated
| @@ -115,7 +116,8 @@ func init() { | |||
| cmdKeeper.PersistentFlags().StringVar(&cfg.pgSUUsername, "pg-su-username", user, "postgres superuser user name. Used for keeper managed instance access and pg_rewind based synchronization. It'll be created on db initialization. Defaults to the name of the effective user running stolon-keeper. Must be the same for all keepers.") | |||
| cmdKeeper.PersistentFlags().StringVar(&cfg.pgSUPassword, "pg-su-password", "", "postgres superuser password. Needed for pg_rewind based synchronization. If provided it'll be configured on db initialization. Only one of --pg-su-password or --pg-su-passwordfile is required. Must be the same for all keepers.") | |||
| cmdKeeper.PersistentFlags().StringVar(&cfg.pgSUPasswordFile, "pg-su-passwordfile", "", "postgres superuser password file. Requires --pg-su-username. Must be the same for all keepers)") | |||
| cmdKeeper.PersistentFlags().BoolVar(&cfg.debug, "debug", false, "enable debug logging") | |||
| cmdKeeper.PersistentFlags().StringVar(&cfg.logLevel, "log-level", "info", "debug, info (default), warn or error") | |||
| cmdKeeper.PersistentFlags().BoolVar(&cfg.debug, "debug", false, "enable debug logging (deprecated, use log-level instead)") | |||
There was a problem hiding this comment.
spf13/pflag has a MarkDeprecated command, perhaps we should use it:
https://godoc.org/github.com/spf13/pflag#FlagSet.MarkDeprecated
|
Done. |
sgotti
approved these changes
Jul 9, 2017
|
@albertvaka LGTM. Thanks a lot! Merging. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not limit the log level to be only debug or info.