Replaced sprintf with net.JoinHostPort to fix bug with ipv6 #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emdem Thanks for the PR. I honestly never tried stolon with ipv6 addresses so if only this change is needed to make it work I'll merge it. |
|
@sgotti No problem, thanks for open-sourcing! It may not be the only one, but I'll fix them as I find them. I think this covers the proxy at least. |
|
@sgotti I've confirmed that it fixes the issue I was having with the proxy. The following all work: |
|
@emdem Great! We should probably add more tests for ipv6 in future. Merging. Thanks a lot! |
sgotti
added a commit
that referenced
this pull request
Jul 31, 2017
Replaced sprintf with net.JoinHostPort to fix bug with ipv6
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.