Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Removing carriage return from example secret #500

Closed
wants to merge 0 commits into from

Conversation

whelgeson
Copy link

The example secret is encoded with a carriage return which causes problems with cluster auth when using the default example scripts. Although this password should be changed, users who want to quickly test out stolon in minikube will find that they are unable to authenticate into the cluster using password1.

@sgotti
Copy link
Member

sgotti commented Jun 4, 2018

@whelgeson Thanks for the PR. It LGTM. k8s tests are failing because you based this on v0.10.0 tag. Can you please rebase on master?

Just curious: also with the carriage return it always worked correctly with the default k8s example since in https://github.com/sorintlab/stolon/blob/master/cmd/keeper/cmd/keeper.go#L152-L168

readPasswordFromFile uses strings.TrimSpace that will remove the leading \n.

Where did you discovered the issue?

@whelgeson
Copy link
Author

This was with Minikube v0.25.0 on Windows 10 w/HyperV. I don't have the setup available right now as it's been a few months since I ran into it. But, what I did was expose stolon-proxy-service as a nodeport and tried to connect to the proxy service but found myself unable to authenticate into postgresql unless I pasted in the default password with a newline character.

@sgotti
Copy link
Member

sgotti commented Jun 5, 2018

@whelgeson Thanks for the explanation. Can you please squash the commits in an unique one based on master?

@whelgeson whelgeson force-pushed the b64-encoding-error branch from 733d3c9 to 1e51c10 Compare June 5, 2018 21:00
@whelgeson whelgeson closed this Jun 7, 2018
@whelgeson whelgeson force-pushed the b64-encoding-error branch from 1e51c10 to d2e2b29 Compare June 7, 2018 19:29
@sgotti sgotti added this to the v0.11.0 milestone Jun 7, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants