Support JSON output in stolonctl status #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! And apologies, missed that issue! |
sgotti
requested changes
Apr 10, 2019
| } else { | ||
| stdout("Master Keeper: (none)") | ||
| } | ||
| master := cd.Cluster.Status.Master |
There was a problem hiding this comment.
cluster.Available should be set to true here or it'll always be false
|
@sgotti thanks for the review and bug spot! I've updated this and it looks like CI has passed now. |
|
@hmac Thanks! Merging. |
sgotti
approved these changes
Apr 13, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows you to pass a
--formatflag tostolonctl statusto specify the output format. The available options aretext(the current output format) andjson, which produces the same data but in a structured format. The idea is that you can build automation around this information without relying on the semi-structured human-readable format.