proxy: stop listening on error or empty proxyConf. #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since multiple proxies can be load balanced, the lb needs to know which proxy is healthy. Before this patch on error communicating with etcd or with an empty proxyConf the proxy closes connections to the previous master but continues accepting connections and closing them instantly. With this patch, on error communicating with etcd or with empty proxyConf the proxy stops listening. It will restart listening on successful etcd communication and a populated proxyConf. In this way a load balancer with a standard tcp check will detect the proxy as not healthy and not balance to it. This is enabled by default and can be disabled with `--stop-listening=false`
sgotti
added a commit
to sgotti/stolon
that referenced
this pull request
Oct 28, 2015
…tcd_error_empty_proxyconf proxy: stop listening on error or empty proxyConf.
sgotti
added a commit
that referenced
this pull request
Oct 28, 2015
…_empty_proxyconf proxy: stop listening on error or empty proxyConf.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since multiple proxies can be load balanced, the lb needs to know which proxy
is healthy.
Before this patch on error communicating with etcd or with an empty proxyConf
the proxy closes connections to the previous master but continues accepting
connections and closing them instantly.
With this patch, on error communicating with etcd or with empty proxyConf the
proxy stops listening. It will restart listening on successful etcd
communication and a populated proxyConf.
In this way a load balancer with a standard tcp check will detect the proxy as
not healthy and not balance to it.
This is enabled by default and can be disabled with
--stop-listening=false