Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix range(::HalfInteger; stop, length) #28

Merged
merged 5 commits into from
Dec 25, 2020
Merged

Fix range(::HalfInteger; stop, length) #28

merged 5 commits into from
Dec 25, 2020

Conversation

sostock
Copy link
Owner

@sostock sostock commented Dec 25, 2020

Before:

julia> range(HalfInt(1/2), stop=HalfInt(3), length=5)
5-element LinRange{Half{Int64}}:
Error showing value of type LinRange{Half{Int64}}:
ERROR: InexactError: Int64(2.25)
Stacktrace:
[...]

After:

julia> range(HalfInt(1/2), stop=HalfInt(3), length=5)
0.5:0.625:3.0

@codecov-io
Copy link

codecov-io commented Dec 25, 2020

Codecov Report

Merging #28 (6dea19c) into master (47ebe89) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          205       208    +3     
=========================================
+ Hits           205       208    +3     
Impacted Files Coverage Δ
src/HalfIntegers.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47ebe89...6dea19c. Read the comment docs.

@sostock sostock merged commit e1b136d into master Dec 25, 2020
@sostock sostock deleted the range branch December 25, 2020 14:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants