Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Base.hastypemax method #42

Merged
merged 2 commits into from
Sep 18, 2021
Merged

Add Base.hastypemax method #42

merged 2 commits into from
Sep 18, 2021

Conversation

sostock
Copy link
Owner

@sostock sostock commented Sep 18, 2021

Because the generic fallback returns the wrong result for BigHalfInt.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2021

Codecov Report

Merging #42 (a9b61a1) into master (b3c9e78) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   99.19%   99.20%           
=======================================
  Files           1        1           
  Lines         249      250    +1     
=======================================
+ Hits          247      248    +1     
  Misses          2        2           
Impacted Files Coverage Δ
src/HalfIntegers.jl 99.20% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3c9e78...a9b61a1. Read the comment docs.

@sostock sostock merged commit 2296f9d into master Sep 18, 2021
@sostock sostock deleted the hastypemax branch September 18, 2021 19:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants