Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix range tests on Julia master #44

Merged
merged 5 commits into from
Jan 24, 2022
Merged

Fix range tests on Julia master #44

merged 5 commits into from
Jan 24, 2022

Conversation

sostock
Copy link
Owner

@sostock sostock commented Jan 21, 2022

Some range calls that would create a StepRange or UnitRange now create a StepRangeLen instead. This PR adapts the tests, adds implementations for Base.range_start_length and Base.range_stop_length and simplifies the range tests.

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2022

Codecov Report

Merging #44 (40a09dd) into master (4923741) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files           1        1           
  Lines         250      250           
=======================================
  Hits          248      248           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4923741...40a09dd. Read the comment docs.

@sostock sostock merged commit 94cbe33 into master Jan 24, 2022
@sostock sostock deleted the range-tests-1.8 branch January 24, 2022 19:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants