Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Remove getOverlayMount() and getGlobalDebugMount() #3318

Merged
merged 4 commits into from
Apr 9, 2019

Conversation

felixfbecker
Copy link
Contributor

@felixfbecker felixfbecker commented Apr 9, 2019

Fixes #3228.

Only GitHub used this, but shouldn't, see #3228.
After removing, they always append to document.body, so there is not reason to have them configurable or subscribe to the mutations (which has a perf impact). It's safe to assume document.body never gets removed from any code host DOM.

Test Plan

Code Hosts
  • GitHub
  • GitHub Enterprise
  • Refined GitHub
  • Phabricator
  • Phabricator integration
  • Bitbucket
  • Gitlab
Browsers
  • Chrome
  • Firefox

@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #3318 into master will decrease coverage by 0.11%.
The diff coverage is 100%.

Impacted Files Coverage Δ
client/browser/src/libs/github/extensions.tsx 94.11% <ø> (-2.18%) ⬇️
.../code_intelligence/code_intelligence_test_utils.ts 92.3% <100%> (+0.3%) ⬆️
...lient/browser/src/libs/github/code_intelligence.ts 41.5% <100%> (-4.58%) ⬇️
...r/src/libs/code_intelligence/code_intelligence.tsx 64.07% <100%> (-0.05%) ⬇️
cmd/frontend/backend/go_importers.go 22.22% <0%> (-37.5%) ⬇️
cmd/frontend/backend/repos_vcs.go 22.03% <0%> (-7.63%) ⬇️
cmd/frontend/backend/repos.go 28.71% <0%> (-2.98%) ⬇️

@felixfbecker felixfbecker added the bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. label Apr 9, 2019
@felixfbecker felixfbecker changed the title Remove getOverlayMount() Remove getOverlayMount() and getGlobalDebugMount() Apr 9, 2019
Copy link
Contributor

@lguychard lguychard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@felixfbecker felixfbecker merged commit 8eb5ae6 into master Apr 9, 2019
@felixfbecker felixfbecker deleted the rm-get-overlay-mount branch April 9, 2019 11:09
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
browser-extension bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants