This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Allow changing the overlay mount location #8340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rel https://github.com/sourcegraph/sourcegraph/issues/3228#issuecomment-481174882 On GitLab merge request pages, the diff tab is always present. As a result, when switching tabs, the hover overlay remains visible, since it is by default mounted to `document.body`, and as such is not affected by the change in visibility of the diff tab. This PR introduces the ability to customize the hover overlay mount location, through `CodeHost.getHoverOverlayMountLocation()`. If `CodeHost.getHoverOverlayMountLocation()` is unspecified, or if it returns `null`, the hover overlay will be mounted to document.body. If the custom mount location is removed from the DOM, the hover overlay will be mounted to document.body again.
lguychard
force-pushed
the
lg/fix-gitlab-hover-mr
branch
from
5aa7f93 to
ee2c93f
Compare
|
Code LGTM. For my understanding, could you describe what happens (in this code) specifically in Gitlab when the user is switching tabs on an MR? |
Then there's some defensive code accounting for |
felixfbecker
approved these changes
Feb 10, 2020
|
That could be great to add in a comment somewhere as an example! |
|
Added as a doc block to |
lguychard
force-pushed
the
lg/fix-gitlab-hover-mr
branch
from
0fb0f8d to
9f1b1fc
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rel https://github.com/sourcegraph/sourcegraph/issues/3228#issuecomment-481174882
On GitLab merge request pages, the diff tab is always present. As a result, when switching tabs, the hover overlay remains visible, since it is by default mounted to
document.body, and as such is not affected by the change in visibility of the diff tab.This PR introduces the ability to customize the hover overlay mount location, through
CodeHost.getHoverOverlayMountLocation(). IfCodeHost.getHoverOverlayMountLocation()is unspecified, or if it returnsnull, the hover overlay will be mounted to document.body. If the custom mount location is removed from the DOM, the hover overlay will be mounted to document.body again.