Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

navigation-fixes: #178

Merged
merged 6 commits into from
Sep 8, 2015
Merged

navigation-fixes: #178

merged 6 commits into from
Sep 8, 2015

Conversation

cheshirsky
Copy link
Member

navigation-fixes:
8416038 
- multiple tags support is added;
- templates extending ability;
- specs validation is fixed;
@robhrt7
Copy link
Member

robhrt7 commented Aug 28, 2015

Js Hint fails

robhrt7
robhrt7 reviewed Aug 30, 2015
View reviewed changes
assets/js/modules/globalNav.js
@@ -24,6 +24,7 @@ define([
"showPreviews": false,
"sortType": "sortByDate",
"sortDirection":"forward",
"delimeter": " ",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be comma by default. Could you please also add some info about this in generated nav documentation https://github.com/sourcejs/Source/blob/master/docs/data-nav/readme.md?

@robhrt7
Copy link
Member

robhrt7 commented Aug 30, 2015

Do you use specs validation plugin in Backbase?

@robhrt7
Copy link
Member

robhrt7 commented Aug 30, 2015

Is this somehow related to external templates issue? #174

Could you please next time use more commits, so it would be easier to track specific changes?

@cheshirsky
Copy link
Member Author

Is this somehow related to external templates issue? #174

yes

Could you please next time use more commits, so it would be easier to track specific changes?

Yes, for sure.

Do you use specs validation plugin in Backbase?

No, I don't think so.

Js Hint fails

Fixed. But checks are failed. By the way, I can't see any reasons or explanations.

@robhrt7
Copy link
Member

robhrt7 commented Aug 31, 2015

Now CasperJS tests are failing, seems like there's a JS error on the page in clean SourceJS set-up.

Error:    TypeError: 'undefined' is not an object (evaluating 'obj['tag'].indexOf')
file:     http://127.0.0.1:8080/source/assets/js/modules/globalNav.js
line:     155
function: 
FAIL JS errors found: TypeError: 'undefined' is not an object (evaluating 'obj['tag'].indexOf')
#    type: fail
#    file: test/casperjs/common.js:40
#    code: test.fail("JS errors found: "+ error.msg);
#    subject: false

robhrt7
robhrt7 reviewed Aug 31, 2015
View reviewed changes
docs/data-nav/readme.md
@@ -66,7 +66,7 @@ If there is no description, or you want to leave custom text, just use this extr

## Filtering by tag

As it's possible to define different tags for specs in `info.json` files (more in [docs](/docs/info-json/)), we can use them to filter custom navigation tree.
As it's possible to define different tags for specs in `info.json` files (more in [docs](/docs/info-json/)), we can use them to filter custom navigation tree. It is also possible to define more than one tag for each spec. You can use "," as a delimeter, e.g. `templates,navigation`. Delimeter is also configurable (you can change it in `globalNav` options object).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't mention about delimiter configuration, it's too much.

@cheshirsky
Copy link
Member Author

Now CasperJS tests are failing, seems like there's a JS error on the page in clean SourceJS set-up.

I can't see checking problems :(

robhrt7
robhrt7 reviewed Aug 31, 2015
View reviewed changes
assets/js/modules/globalNav.js
@@ -144,8 +149,11 @@ define([
* @returns {Boolean} true if spec shoud be skipped.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct JSDom, first param is now not only a String, but could also be an array.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@robhrt7 robhrt7 mentioned this pull request Aug 31, 2015
Closed
robhrt7 added a commit that referenced this pull request Sep 8, 2015
@robhrt7
Merge pull request #178 from sourcejs/navigation-fixes
3de7279 
generated navigation improvements
@robhrt7 robhrt7 merged commit 3de7279 into 0.5.6-dev Sep 8, 2015
@robhrt7 robhrt7 deleted the navigation-fixes branch September 8, 2015 21:10
robhrt7 added a commit that referenced this pull request Sep 20, 2015
@robhrt7
#178: generated navigation docs update
4f49a94
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cheshirsky @robhrt7