updated ohai recipe to work with v4.1.0 of the ohai cookbook #409
Conversation
|
@miketheman Please increase the priority of this pull request. This is a huge problem for us. We have ohai plugins which rely on the ohai cookbook @4.0.0+. This is now preventing us from deploying new cookbooks which rely on the newer ohai cookbook and also this nginx cookbook. Thanks! also: #419 |
|
Odd that this is only getting recent attention, but my infra is unfortunately being held back as well Any expediting would be appreciated :) |
|
fwiw, I'm not even using nginx cookbook, so for now, i can just update to 3.0 in my berksfile via git ref. |
|
Any update to this PR?? |
|
Since there hasn't been any movement on this, we've cloned the PR and deployed it. Works fine, but not really happy to do it since we will have to more diligent in monitoring for any future patches to ensure this problem doesn't come up again. |
|
👍 👍 👍 👍 👍 👍 pleaasse help @miketheman |
|
I'd love to get everyone on the new Ohai cookbook since I wrote that, but doing so removes support for Chef 11, which a lot of users are still one. I've prepped a PR for a final 2.X release of this cookbook that resolves some of the Ohai issues and allows using the 3.X Ohai cookbook. After that in the 3.X version of this cookbook, where only Chef 12+ is supported we can require Ohai 4.X |
|
|
||
| recipe 'nginx', 'Installs nginx package and sets up configuration with Debian apache style with sites-enabled/sites-available' | ||
| recipe 'nginx::source', 'Installs nginx from source and sets up configuration with Debian apache style with sites-enabled/sites-available' | ||
|
|
||
| depends 'apt', '~> 2.2' | ||
| depends 'bluepill', '~> 2.3' | ||
| depends 'build-essential', '~> 2.0' | ||
| depends 'ohai', '~> 2.0' | ||
| depends 'ohai', '~> 4.1.0' |
There was a problem hiding this comment.
Why such strict versioning being used here? Shouldn't ~> 4.0 be enough?
|
4.1 would be ideal as it would allow any 4.x cookbook but set the minimum to 4.1 |
Changes borrowed from sous-chefs#409
|
Thanks for opening this PR. With the merge of the chef_nginx codebase back into the nginx cookbook I believe it’s no longer necessary. I’m going to close this out now, and I hope you can check out the massive changes that landed on master here #435 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Some changes were made in v4.1.0 of the Ohai cookbook that broke Nginx, specifically it was throwing a method not found for the location of the plugin_path.
This change is