matching interface changes in notion package #126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday Notion changed some type definitions, making them incompatible with the types defined in by notion-to-md. Those changes are here and here.
I went looking for a bit of robustness so this doesn't get broken by arbitrary changes again from Notion in the future. Looks like another package notion types would keep up with changes like this (albeit less precisely than the aliases defined here. Unless the maintainers are averse to adding additional packages I'll see if this could be a more permanent solution than the hotfix here.