Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

matching interface changes in notion package #126

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

artable
Copy link
Contributor

@artable artable commented Feb 19, 2025

Yesterday Notion changed some type definitions, making them incompatible with the types defined in by notion-to-md. Those changes are here and here.

I went looking for a bit of robustness so this doesn't get broken by arbitrary changes again from Notion in the future. Looks like another package notion types would keep up with changes like this (albeit less precisely than the aliases defined here. Unless the maintainers are averse to adding additional packages I'll see if this could be a more permanent solution than the hotfix here.

@souvikinator
Copy link
Owner

@artable thanks, that's super helpful. Agreed it's hard to keep track of Notion API changes. I’ll check out the mentioned package. Right now, 3.x.x is focused only on bug fixes, but I might consider using it in v4 (currently in development, updates here: #112).

Would love your views on the v4 :))

@souvikinator souvikinator merged commit 6a4a124 into souvikinator:master Feb 21, 2025
@souvikinator
Copy link
Owner

Thanks for your contribution. The new release v3.1.6 is out.

Copy link
Owner

@souvikinator souvikinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants