Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Port Editors #11

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Port Editors #11

wants to merge 3 commits into from

Conversation

nkasmanoff
Copy link
Contributor

No description provided.

@nkasmanoff nkasmanoff mentioned this pull request Dec 17, 2023
23 tasks
@jejjohnson
Copy link
Member

jejjohnson commented Dec 18, 2023

Would we be able to follow the same format as the helio_tools package? Try to make all "editors" functional or a data class? For example:

Functional

s_map: Map = transfrom(s_map, *args, **kwargs)

Dataclass

@dataclasses.dataclass
class Function:
   param: int = ...
   param2: float = ...
   
   def __call__(self, s_map: Map) -> Map:
       data: np.ndarray = s_map.data
        # do something ...
        data: np.ndarray = ....
        return Map(data, s_map.fits_header)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants