Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

roman/new-rmaps-aboffset-apcorr #1097

Conversation

alphasentaurii
Copy link
Collaborator

@alphasentaurii alphasentaurii commented Nov 5, 2024

Resolves CCD-1526

Adds new reference mapping types AB-Vega Offset (aboffset) and Aperture Correction (apcorr) for Roman

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
news fragment change types...
  • changes/<PR#>.hst.rst: HST reference files
  • changes/<PR#>.jwst.rst: JWST reference files
  • changes/<PR#>.roman.rst: Roman reference files
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.testing.rst: change to tests or test automation
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

@alphasentaurii alphasentaurii requested a review from a team as a code owner November 5, 2024 17:16
@alphasentaurii alphasentaurii merged commit 68d82a3 into spacetelescope:master Nov 5, 2024
10 checks passed
@alphasentaurii alphasentaurii deleted the CCD-1526-rom-refs-aboffset-apcorr branch November 5, 2024 20:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants