Skip to content

Commit

Permalink
UI tweaks from Patrick's feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
kecnry committed Mar 21, 2022
1 parent ef27c7e commit 7edc9e3
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 7 deletions.
4 changes: 2 additions & 2 deletions jdaviz/components/tooltip.vue
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ const tooltips = {
'plugin-line-lists-line-name': 'Name this whatever you want',
'plugin-line-lists-custom-rest': 'This is a float or integer',
'plugin-line-lists-add-custom-line': 'Add line to the custom list',
'plugin-line-lists-line-identify-chip-active': 'Click to unidentify line',
'plugin-line-lists-line-identify-chip-inactive': 'Use tool in spectrum viewer to identify line',
'plugin-line-lists-line-identify-chip-active': 'Currently highlighted line. Click to clear current selection.',
'plugin-line-lists-line-identify-chip-inactive': 'No line currently highlighted. Use selection tool in spectrum viewer to identify a line.',
'plugin-line-lists-line-visible': 'Toggle showing the line in the spectrum viewer',
'plugin-line-lists-line-identify': 'Highlight this line in the spectrum viewer for easy identification',
'plugin-line-analysis-sync-identify': 'Lock/unlock selection with identified line',
Expand Down
13 changes: 10 additions & 3 deletions jdaviz/configs/default/plugins/line_lists/line_lists.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,23 @@
<j-docs-link :link="'https://jdaviz.readthedocs.io/en/'+vdocs+'/'+config+'/plugins.html#line-lists'">Plot lines from preset or custom line lists.</j-docs-link>
</v-row>

<j-plugin-section-header>Identified Line</j-plugin-section-header>
<v-row>
<j-docs-link>Highlight a line and identify its name by using the line selection tool in the spectrum viewer.</j-docs-link>
</v-row>
<v-row v-if="rs_enabled">
<j-tooltip v-if='identify_label' tipid='plugin-line-lists-line-identify-chip-active'>
<v-chip
v-if="identify_label"
label=true
@click="set_identify(null)"
><img class="color-to-accent" :src="identify_line_icon" width="20"/> {{ identify_label }}</v-chip>
@click="set_identify(null)">
<img class="color-to-accent" :src="identify_line_icon" width="20"/> {{ identify_label }}
</v-chip>
</j-tooltip>
<j-tooltip v-else tipid='plugin-line-lists-line-identify-chip-inactive'>
<v-chip>no line identified</v-chip>
<v-chip label=true>
<img :src="identify_line_icon" width="20"/> no line identified
</v-chip>
</j-tooltip>
</v-row>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
:items="line_items"
v-model="selected_line"
label="Line"
hint="Assign computed centroid to line."
hint="Select reference line."
persistent-hint
></v-select>
</v-col>
Expand All @@ -128,7 +128,7 @@
class="mt-0 pt-0"
type="number"
label="Redshift"
hint="Redshift that will be applied by assigning centroid."
hint="Redshift that will be applied by assigning centroid to the selected line."
persistent-hint
disabled
></v-text-field>
Expand Down

0 comments on commit 7edc9e3

Please # to comment.