Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move region/Subset translation code to glue-astronomy #1570

Open
3 tasks
Jdaviz-Triage-Bot opened this issue Aug 12, 2022 · 2 comments
Open
3 tasks

Move region/Subset translation code to glue-astronomy #1570

Jdaviz-Triage-Bot opened this issue Aug 12, 2022 · 2 comments
Labels
api API change

Comments

@Jdaviz-Triage-Bot
Copy link

Jdaviz-Triage-Bot commented Aug 12, 2022

Reporter: pllim

This is a follow-up of #1463 . In that PR, because it was blocking something else and we needed a fast turnaround time, some code that could have been in glue-astronomy were added straight into Jdaviz. I am talking about the regions2roi function in jdaviz/core/region_translators.py module. It is better to move that code to glue-astronomy so more people can benefit from the generic translation tools.

So a few things we need to do:

  • Move that code to glue-astronomy. Get that released upstream.
  • Use the released glue-astronomy code in Jdaviz, deprecate the equivalent code in Jdaviz.
  • After a few major Jdaviz releases, remove the deprecated code from Jdaviz codebase.

This probably will drag on for a while and the items above should be sub-tasks.

🐱


DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter. If any information is incorrect, please contact Duy Nguyen

@pllim pllim added the api API change label Aug 12, 2022
@stscijgbot-jwql
Copy link

This issue is tracked on JIRA as JDAT-2678.

@stscijgbot-jwql
Copy link

Comment by Duy Nguyen on JIRA:

NOTICE: A corresponding GitHub issue was automatically created: #1570

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
api API change
Projects
None yet
Development

No branches or pull requests

3 participants