Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix dark theme support for model parameter names #1029

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jan 5, 2022

Description

This pull request fixes dark theme support for model parameter names in the model fitting plugin.

Fixes #1028

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added UI/UX😍 trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Jan 5, 2022
@kecnry kecnry added this to the 2.3 milestone Jan 5, 2022
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2022-01-05 133629

LGTM. Thanks for the quick fix!

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.23%. Comparing base (49d6046) to head (ce365f2).
Report is 2772 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1029   +/-   ##
=======================================
  Coverage   73.23%   73.23%           
=======================================
  Files          75       75           
  Lines        5657     5657           
=======================================
  Hits         4143     4143           
  Misses       1514     1514           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim pllim merged commit 14f214e into spacetelescope:main Jan 5, 2022
@kecnry kecnry deleted the fitting-parameter-dark-mode branch January 5, 2022 19:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model fitting plugin: Param text color not compatible with dark mode
2 participants