Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

plugins: spectral_subset choice from "None" to "Entire Spectrum" #1074

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Feb 11, 2022

Description

This pull request updates all remaining mentions of spectral_subset = "None" in plugins to be "Entire Spectrum" for self-consistency.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added UI/UX😍 trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Feb 11, 2022
@kecnry kecnry added this to the 2.3 milestone Feb 11, 2022
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.74%. Comparing base (a496fa7) to head (f902de3).
Report is 2613 commits behind head on main.

Files Patch % Lines
...daviz/configs/default/plugins/collapse/collapse.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1074      +/-   ##
==========================================
- Coverage   75.84%   75.74%   -0.10%     
==========================================
  Files          81       81              
  Lines        6234     6234              
==========================================
- Hits         4728     4722       -6     
- Misses       1506     1512       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry
Copy link
Member Author

kecnry commented Feb 11, 2022

No new lines were added to the code, so can we please ignore the coverage warnings, please? 🥺

Copy link
Contributor

@javerbukh javerbukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No controversy here, thanks!

@kecnry kecnry merged commit d7e4927 into spacetelescope:main Feb 14, 2022
@kecnry kecnry deleted the plugin-entire-spectrum branch February 14, 2022 14:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cubeviz no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants