Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix redshift RV input float parsing #1086

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Feb 17, 2022

Description

This pull request fixes a UI bug when entering RV manually. This was inadvertently introduced in #1036 (953d9d1). The change to use FloatHandleEmpty instead of Any requires string->float casting to be done within JS.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added UI/UX😍 trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Feb 17, 2022
@kecnry kecnry added this to the 2.3 milestone Feb 17, 2022
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.89%. Comparing base (ddd3c25) to head (7208b69).
Report is 2599 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1086   +/-   ##
=======================================
  Coverage   75.89%   75.89%           
=======================================
  Files          82       82           
  Lines        6278     6278           
=======================================
  Hits         4765     4765           
  Misses       1513     1513           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ibusko ibusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough fix. I checked in the demo notebook and it works fine.

@kecnry
Copy link
Member Author

kecnry commented Feb 18, 2022

No idea why CI is failing, seems to be unrelated to the changes here though - @pllim?

@pllim
Copy link
Contributor

pllim commented Feb 18, 2022

Might be another manifestation of something I am trying to fix at astropy/astropy#12875 . Okay to ignore here for now.

@pllim pllim merged commit c523362 into spacetelescope:main Feb 18, 2022
@pllim
Copy link
Contributor

pllim commented Feb 18, 2022

Thanks!

@kecnry kecnry deleted the redshift-rv-fix branch February 18, 2022 18:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants