Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

TST: Silence specutils warning in fixture #1093

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Feb 21, 2022

Description

This pull request is to handle new warning that pops up due to astropy/specutils#922 in newly released specutils.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Feb 21, 2022
@pllim pllim added this to the 2.3 milestone Feb 21, 2022
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.89%. Comparing base (c523362) to head (6871b1f).
Report is 2570 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1093   +/-   ##
=======================================
  Coverage   75.89%   75.89%           
=======================================
  Files          82       82           
  Lines        6278     6278           
=======================================
  Hits         4765     4765           
  Misses       1513     1513           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry
Copy link
Member

kecnry commented Feb 21, 2022

This will be needed with specutils 1.7 which is now pinned in #1060

@kecnry kecnry merged commit 30cb3d6 into spacetelescope:main Feb 21, 2022
@pllim pllim deleted the shhhh branch February 21, 2022 18:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
mosviz no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants