Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DOC: Use intersphinx in glue dev doc link #1100

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Feb 22, 2022

Description

This pull request is to use intersphinx to an important link for devs that @astrofrog mentioned this morning. Not sure how to make it easier to find though.

http://docs.glueviz.org/en/stable/customizing_guide/viewer.html

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Feb 22, 2022
@pllim pllim added this to the 2.3 milestone Feb 22, 2022
@github-actions github-actions bot added the documentation Explanation of code and concepts label Feb 22, 2022
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #1100 (15092b9) into main (c6ba6f5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1100   +/-   ##
=======================================
  Coverage   76.03%   76.03%           
=======================================
  Files          82       82           
  Lines        6284     6284           
=======================================
  Hits         4778     4778           
  Misses       1506     1506           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6ba6f5...15092b9. Read the comment docs.

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somewhere is better than nowhere!

@kecnry kecnry merged commit 29cd47f into spacetelescope:main Feb 22, 2022
@pllim pllim deleted the dev-doc-viewer branch February 22, 2022 16:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Explanation of code and concepts no-changelog-entry-needed changelog bot directive Ready for final review trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants