Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Simple Aperture Photometry Plugin: Auto-populate background #1109

Merged
merged 5 commits into from
Feb 25, 2022

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Feb 23, 2022

Description

This pull request is to implement the most minimal version of background auto-population as proposed at #1050 (comment) .

Fixes #1050

Screenshot 2022-02-23 181416

TODO

  • Is there some nicer way to control the GUI behavior? Maybe @kecnry knows. He mentioned observe.
  • Add tests.
  • Add change log.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added this to the 2.3 milestone Feb 23, 2022
@github-actions github-actions bot added documentation Explanation of code and concepts imviz labels Feb 23, 2022
@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #1109 (e9c3227) into main (074d51d) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1109      +/-   ##
==========================================
+ Coverage   76.37%   76.46%   +0.08%     
==========================================
  Files          82       82              
  Lines        6425     6449      +24     
==========================================
+ Hits         4907     4931      +24     
  Misses       1518     1518              
Impacted Files Coverage Δ
...imviz/plugins/aper_phot_simple/aper_phot_simple.py 95.14% <100.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 074d51d...e9c3227. Read the comment docs.

@pllim pllim force-pushed the imviz-phot-bg-sub branch from 321401f to b90b423 Compare February 24, 2022 22:11
pllim and others added 5 commits February 24, 2022 19:40
* v-model with observe requires more traitlets, but ensures the plugin will remain in sync if changes are made through the API or another instance of the UI.
* along with some renaming and minor refactoring now that values are stored internally a little differently.  Also hide items in the plugin until data is selected to avoid needing to deal with things being changed before.
@pllim pllim force-pushed the imviz-phot-bg-sub branch from 5840831 to e9c3227 Compare February 25, 2022 00:40
@pllim pllim marked this pull request as ready for review February 25, 2022 00:58
Copy link
Contributor

@ibusko ibusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the generated background values seem sensible based on the regions I was selecting to test.

@rosteen rosteen merged commit f814330 into spacetelescope:main Feb 25, 2022
@pllim pllim deleted the imviz-phot-bg-sub branch February 25, 2022 16:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Explanation of code and concepts imviz Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Imviz: Auto-populate background in aperture photometry plugin
4 participants