-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Simple Aperture Photometry Plugin: Auto-populate background #1109
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1109 +/- ##
==========================================
+ Coverage 76.37% 76.46% +0.08%
==========================================
Files 82 82
Lines 6425 6449 +24
==========================================
+ Hits 4907 4931 +24
Misses 1518 1518
Continue to review full report at Codecov.
|
321401f
to
b90b423
Compare
* v-model with observe requires more traitlets, but ensures the plugin will remain in sync if changes are made through the API or another instance of the UI. * along with some renaming and minor refactoring now that values are stored internally a little differently. Also hide items in the plugin until data is selected to avoid needing to deal with things being changed before.
5840831
to
e9c3227
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, the generated background values seem sensible based on the regions I was selecting to test.
Description
This pull request is to implement the most minimal version of background auto-population as proposed at #1050 (comment) .
Fixes #1050
TODO
observe
.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.CHANGES.rst
?