Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MNT: Remove unused minversion check #1137

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Mar 1, 2022

Description

This pull request is to remove minversion checks that is no longer needed.

astropy>=4.3

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added Ready for final review trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Mar 1, 2022
@pllim pllim added this to the 2.3 milestone Mar 1, 2022
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #1137 (51fe550) into main (f7ccdcf) will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1137      +/-   ##
==========================================
+ Coverage   76.62%   76.65%   +0.03%     
==========================================
  Files          82       82              
  Lines        6495     6482      -13     
==========================================
- Hits         4977     4969       -8     
+ Misses       1518     1513       -5     
Impacted Files Coverage Δ
jdaviz/configs/mosviz/plugins/viewers.py 82.43% <0.00%> (+0.85%) ⬆️
jdaviz/configs/specviz/plugins/viewers.py 64.91% <100.00%> (-0.17%) ⬇️
jdaviz/core/astrowidgets_api.py 98.66% <100.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ccdcf...51fe550. Read the comment docs.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rosteen rosteen merged commit f58a43d into spacetelescope:main Mar 1, 2022
@pllim pllim deleted the rm-old-minversion-astropy branch March 1, 2022 23:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
mosviz no-changelog-entry-needed changelog bot directive Ready for final review specviz trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants