-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
MNT: Drop Python 3.7 support #1145
Conversation
Ignore the |
Codecov Report
@@ Coverage Diff @@
## main #1145 +/- ##
==========================================
+ Coverage 76.72% 76.75% +0.02%
==========================================
Files 87 82 -5
Lines 6655 6482 -173
==========================================
- Hits 5106 4975 -131
+ Misses 1549 1507 -42
Continue to review full report at Codecov.
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
9a279ba
to
d0fddd3
Compare
I had the same problems in glue-viz/glue-jupyter#297 – looks like the warnings filter does not help if it raises already in the collection step. |
Yeah, @dhomeier . It is already fixed in |
Yes, I've seen it, just had not found the right devdeps environment in glue-jupyter to test against that. |
to be consistent with upstream (astropy, regions, etc). TST: Clean up cron job workflow; it is unnecessarily complicated. TST: We cannot use Python 3.10 with stable Glue because its compatibility patch is not yet released.
I need this in and I haven't heard objection, so |
Description
MNT: Drop Python 3.7 support to be consistent with upstream (astropy, regions, etc).
TST: Clean up cron job workflow; it is unnecessarily complicated.
This is required for:
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.CHANGES.rst
?