Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MNT: Drop Python 3.7 support #1145

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Mar 4, 2022

Description

MNT: Drop Python 3.7 support to be consistent with upstream (astropy, regions, etc).

TST: Clean up cron job workflow; it is unnecessarily complicated.

This is required for:

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added this to the 2.4 milestone Mar 4, 2022
@pllim pllim requested a review from havok2063 March 4, 2022 15:07
@github-actions github-actions bot added documentation Explanation of code and concepts testing labels Mar 4, 2022
@pllim pllim mentioned this pull request Mar 4, 2022
23 tasks
@pllim
Copy link
Contributor Author

pllim commented Mar 4, 2022

Ignore the OS X - Python 3.7 Expected — Waiting for status to be reported status (and so on). I need to update branch protection rules after this is merged. So that means this PR needs admin rights to merge (either @rosteen or myself can do it).

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #1145 (3a4cd8c) into main (b2e6c8d) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 3a4cd8c differs from pull request most recent head e0f639f. Consider uploading reports for the commit e0f639f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1145      +/-   ##
==========================================
+ Coverage   76.72%   76.75%   +0.02%     
==========================================
  Files          87       82       -5     
  Lines        6655     6482     -173     
==========================================
- Hits         5106     4975     -131     
+ Misses       1549     1507      -42     
Impacted Files Coverage Δ
jdaviz/configs/cubeviz/plugins/viewers.py 95.23% <0.00%> (-2.39%) ⬇️
jdaviz/core/tools.py 74.57% <0.00%> (-1.47%) ⬇️
jdaviz/app.py 88.95% <0.00%> (-1.03%) ⬇️
jdaviz/configs/specviz/plugins/viewers.py 64.91% <0.00%> (-0.29%) ⬇️
jdaviz/configs/imviz/plugins/viewers.py 82.73% <0.00%> (-0.25%) ⬇️
jdaviz/configs/default/plugins/__init__.py 100.00% <0.00%> (ø)
...iz/configs/default/plugins/export_plot/__init__.py
...nfigs/default/plugins/plot_options/plot_options.py
...configs/default/plugins/export_plot/export_plot.py
jdaviz/components/toolbar_nested.py
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2e6c8d...e0f639f. Read the comment docs.

@pllim

This comment was marked as outdated.

@pllim

This comment was marked as outdated.

@pllim pllim force-pushed the drop-python-3.7 branch 2 times, most recently from 9a279ba to d0fddd3 Compare March 4, 2022 16:03
@dhomeier
Copy link
Collaborator

dhomeier commented Mar 4, 2022

Why is this not working for that one job? 🤔

I had the same problems in glue-viz/glue-jupyter#297 – looks like the warnings filter does not help if it raises already in the collection step.

@pllim
Copy link
Contributor Author

pllim commented Mar 4, 2022

Yeah, @dhomeier . It is already fixed in glue dev, so it will go away with the next glue release.

@dhomeier
Copy link
Collaborator

dhomeier commented Mar 4, 2022

Yes, I've seen it, just had not found the right devdeps environment in glue-jupyter to test against that.

to be consistent with upstream (astropy, regions, etc).

TST: Clean up cron job workflow; it is unnecessarily complicated.

TST: We cannot use Python 3.10 with stable Glue because its
compatibility patch is not yet released.
@pllim pllim force-pushed the drop-python-3.7 branch from d0fddd3 to e0f639f Compare March 8, 2022 23:01
@pllim
Copy link
Contributor Author

pllim commented Mar 8, 2022

I need this in and I haven't heard objection, so #yolo.

@pllim pllim merged commit d285987 into spacetelescope:main Mar 8, 2022
@pllim pllim deleted the drop-python-3.7 branch March 8, 2022 23:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants