Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

New app.is_tray_item_open_from_name() method #1151

Closed
wants to merge 1 commit into from

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Mar 8, 2022

Description

This pull request is to formally implement app.is_tray_item_open_from_name() that is used in Line Analysis but might be more useful in general. I originally wanted to use it for Compass (#1152) but ended up did not, so this is a separate PR now.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added the no-changelog-entry-needed changelog bot directive label Mar 8, 2022
@pllim pllim added this to the 2.4 milestone Mar 8, 2022
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #1151 (0e44f0b) into main (b2e6c8d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1151      +/-   ##
==========================================
+ Coverage   76.72%   76.73%   +0.01%     
==========================================
  Files          87       87              
  Lines        6655     6658       +3     
==========================================
+ Hits         5106     5109       +3     
  Misses       1549     1549              
Impacted Files Coverage Δ
jdaviz/app.py 90.07% <100.00%> (+0.09%) ⬆️
...igs/specviz/plugins/line_analysis/line_analysis.py 85.06% <100.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2e6c8d...0e44f0b. Read the comment docs.

@kecnry
Copy link
Member

kecnry commented Mar 8, 2022

Woops, related to #1153... if we still want app-level read-access to this, then we can rebase #1153 on top to call this internally. But #1153 will provide the functionality we need from within the plugins themselves.

@pllim pllim marked this pull request as draft March 8, 2022 22:10
@pllim
Copy link
Contributor Author

pllim commented Mar 8, 2022

Well, if we end up not needing this, then there is no need to get it in. I turned this into draft for now.

@pllim pllim closed this Mar 11, 2022
@pllim pllim deleted the app-tray-is-open branch March 11, 2022 14:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants