-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
DOCS: Update cubeviz slice docs #1158
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1158 +/- ##
==========================================
- Coverage 76.86% 76.10% -0.76%
==========================================
Files 87 87
Lines 6661 6667 +6
==========================================
- Hits 5120 5074 -46
- Misses 1541 1593 +52
Continue to review full report at Codecov.
|
docs/cubeviz/plugins.rst
Outdated
@@ -41,6 +41,13 @@ the wavelength entry will update to the exact value of that slice). | |||
|
|||
The spectrum viewer also contains a tool to allow clicking and | |||
dragging in the spectrum plot to choose the currently selected slice. | |||
If another toolbar icon is selected, and then deselected after use, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is best if @kecnry can look at this since he implemented this feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right now this is technically true, but will change slightly if/when #1115 is merged. Maybe it would be simpler to just skip this part about deselecting, etc, and say "When the slice to is active, clicking anywhere on the spectrum viewer will select the nearest slice across all viewers, even if the indicator is off-screen"? The underlying logic for "defaulting" tools is somewhat complex to explain in words, but I think is intuitive and quickly learned just by using it 🤞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I updated the text in the latest commit. Thanks!
Description
This pull request is to address the changed UI since these docs were made and add some more context on toolbar interactions with the slice tool.
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.CHANGES.rst
?