Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move export plot plugin to last in the listing #1160

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Mar 11, 2022

Description

It just bothers me that it is not listed last because usually you export at the end of the workflow. 😆

With this patch (example below from Imviz):

Screenshot 2022-03-11 095357

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Mar 11, 2022
@pllim pllim added this to the 2.4 milestone Mar 11, 2022
@kecnry
Copy link
Member

kecnry commented Mar 11, 2022

Although we can do this for now, it will likely move higher in the list once we decide on an actual "policy" for plugin ordering. The immediate downside to moving it to the bottom now is that the sidebar currently has no ability to "scroll to" when opening a plugin from a viewer toolbar. Granted this same annoyance happens when its at the top and you have other plugins below opened, but now its more apparent from the default app state.

@pllim
Copy link
Contributor Author

pllim commented Mar 11, 2022

Patrick never even used this feature (he said he takes screenshots), so unlikely anyone going to notice and it will stop bothering me, so win-win?

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #1160 (64cb5f3) into main (9d90130) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1160   +/-   ##
=======================================
  Coverage   76.10%   76.10%           
=======================================
  Files          87       87           
  Lines        6667     6667           
=======================================
  Hits         5074     5074           
  Misses       1593     1593           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d90130...64cb5f3. Read the comment docs.

@pllim pllim merged commit d72c718 into spacetelescope:main Mar 17, 2022
@pllim pllim deleted the export-last branch March 17, 2022 15:30
@pllim
Copy link
Contributor Author

pllim commented Mar 17, 2022

Thanks for the discussions and approvals!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants