Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

BUG: Fix load data after imviz.app does not show last loaded data #1178

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Mar 18, 2022

Description

This pull request is to fix #1126

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added the bug Something isn't working label Mar 18, 2022
@pllim pllim added this to the 2.4 milestone Mar 18, 2022
@pllim pllim requested a review from astrofrog March 18, 2022 14:21
@github-actions github-actions bot added the imviz label Mar 18, 2022
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #1178 (bb74d8d) into main (be1d987) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1178      +/-   ##
==========================================
+ Coverage   76.37%   76.47%   +0.09%     
==========================================
  Files          87       87              
  Lines        6723     6728       +5     
==========================================
+ Hits         5135     5145      +10     
+ Misses       1588     1583       -5     
Impacted Files Coverage Δ
jdaviz/app.py 90.13% <100.00%> (-0.16%) ⬇️
jdaviz/configs/imviz/helper.py 98.70% <100.00%> (+0.02%) ⬆️
jdaviz/configs/imviz/plugins/parsers.py 100.00% <100.00%> (ø)
...configs/default/plugins/data_tools/file_chooser.py 69.14% <0.00%> (+3.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be1d987...bb74d8d. Read the comment docs.

@pllim
Copy link
Contributor Author

pllim commented Mar 18, 2022

The failure in jdaviz/configs/imviz/tests/test_simple_aper_phot.py is unrelated and is going to be fixed by #1138

@camipacifici
Copy link
Contributor

Works and also fixes the problem I was seeing with black/gray images when blinking.

@pllim
Copy link
Contributor Author

pllim commented Mar 21, 2022

I think one happy PO = two approvals. So I am going to merge this so we can go back to reviewing the other fix at #1164. 😸 #yolo

@pllim pllim merged commit e25461d into spacetelescope:main Mar 21, 2022
@pllim pllim deleted the imviz-link-before-show branch March 21, 2022 18:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Imviz: load data after imviz.app does not show last loaded data
2 participants