Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MNT: Update dependencies in bug report templates #1204

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Mar 28, 2022

Description

This pull request is to update dependencies listed in our bug report templates. They are a little outdated. This does not affect any code, just the GitHub issue templates.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added Ready for final review trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Mar 28, 2022
@pllim pllim added this to the 2.4 milestone Mar 28, 2022
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go once CI passes!

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #1204 (30d5a4b) into main (752a0fb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1204   +/-   ##
=======================================
  Coverage   77.44%   77.44%           
=======================================
  Files          90       90           
  Lines        7079     7079           
=======================================
  Hits         5482     5482           
  Misses       1597     1597           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 752a0fb...30d5a4b. Read the comment docs.

@kecnry kecnry merged commit bb3254a into spacetelescope:main Mar 28, 2022
@pllim pllim deleted the update-templates branch March 28, 2022 18:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
no-changelog-entry-needed changelog bot directive Ready for final review trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants