-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add esa data parser to cubeviz #1227
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1227 +/- ##
==========================================
- Coverage 77.99% 77.83% -0.16%
==========================================
Files 90 90
Lines 7179 7197 +18
==========================================
+ Hits 5599 5602 +3
- Misses 1580 1595 +15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a hack on super secret data, it is ok to not test as long as Patrick okays this solution.
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks reasonable enough to me (but haven't tested on the actual data locally)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as advertised, loading the data from FITS with a single command:
cubeviz.load_data("Cube.fits")
Description
This pull request is to address esa pipeline data not being loaded into cubeviz.
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.CHANGES.rst
?