Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add esa data parser to cubeviz #1227

Merged
merged 3 commits into from
Apr 5, 2022

Conversation

javerbukh
Copy link
Contributor

@javerbukh javerbukh commented Apr 1, 2022

Description

This pull request is to address esa pipeline data not being loaded into cubeviz.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@javerbukh javerbukh added this to the 2.5 milestone Apr 1, 2022
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #1227 (78f42fd) into main (522392e) will decrease coverage by 0.15%.
The diff coverage is 21.05%.

@@            Coverage Diff             @@
##             main    #1227      +/-   ##
==========================================
- Coverage   77.99%   77.83%   -0.16%     
==========================================
  Files          90       90              
  Lines        7179     7197      +18     
==========================================
+ Hits         5599     5602       +3     
- Misses       1580     1595      +15     
Impacted Files Coverage Δ
jdaviz/configs/cubeviz/plugins/parsers.py 56.61% <21.05%> (-6.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 522392e...78f42fd. Read the comment docs.

@pllim pllim requested a review from PatrickOgle April 1, 2022 16:19
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a hack on super secret data, it is ok to not test as long as Patrick okays this solution.

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks reasonable enough to me (but haven't tested on the actual data locally)

Copy link
Contributor

@PatrickOgle PatrickOgle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised, loading the data from FITS with a single command:
cubeviz.load_data("Cube.fits")

@javerbukh javerbukh merged commit 5ea24d5 into spacetelescope:main Apr 5, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants