Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert "Change default collapse function to sum" #1236

Closed
wants to merge 1 commit into from

Conversation

javerbukh
Copy link
Contributor

Reverts #1229

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #1236 (a54c310) into main (d08a4ea) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1236      +/-   ##
==========================================
- Coverage   77.93%   77.84%   -0.09%     
==========================================
  Files          90       90              
  Lines        7205     7203       -2     
==========================================
- Hits         5615     5607       -8     
- Misses       1590     1596       +6     
Impacted Files Coverage Δ
jdaviz/configs/specviz/plugins/viewers.py 80.24% <ø> (-0.16%) ⬇️
...configs/default/plugins/data_tools/file_chooser.py 65.71% <0.00%> (-3.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df79db5...a54c310. Read the comment docs.

@pllim
Copy link
Contributor

pllim commented Apr 6, 2022

Superseded by #1237

@pllim pllim closed this Apr 6, 2022
@pllim pllim deleted the revert-1229-change_function branch April 6, 2022 20:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants