-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
basic plugin search #1253
basic plugin search #1253
Conversation
* currently synced across multiple instances of the app - may want to have it per-instance in the future, but using 'data' on the app-level seems not to work * currently exact match on the plugin label only. Could extend this to search full text or tags, etc * NOTE: cannot filter the input list to v-expansion-panels as that disrupts the tray_items_open list of indices, so instead we hide the child v-expansion-panel-header/content items.
Codecov Report
@@ Coverage Diff @@
## main #1253 +/- ##
==========================================
+ Coverage 79.62% 80.11% +0.49%
==========================================
Files 90 90
Lines 7223 7353 +130
==========================================
+ Hits 5751 5891 +140
+ Misses 1472 1462 -10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
Description
This pull request implements a search bar at the top of the plugin tray with simple exact-match search on plugin titles to filter plugins in the expansion panels.
v-expansion-panels
as that disrupts thetray_items_open
list of indices, so instead we hide the childv-expansion-panel-header
/v-expansion-panels-content
items.Screen.Recording.2022-04-18.at.10.05.10.AM.mov
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.CHANGES.rst
?