Imviz: Curve of growth plot

[pllim]

Description

This pull request is to add curve of growth plot in Simple Aperture Photometry plugin.

🐱

• Stretch goal: Add tests for radial profile plots.
• Get rid of mysterious traitlet warning. See Imviz: Curve of growth plot #1287 (comment)

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
• Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
• Do the proposed changes follow the STScI Style Guides?
• Are tests added/updated as required? If so, do they follow the STScI Style Guides?
• Are docs added/updated as required? If so, do they follow the STScI Style Guides?
• Did the CI pass? If not, are the failures related?
• Is a change log needed? If yes, is it added to CHANGES.rst?
• Is a milestone set?
• After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

[kecnry]

Gotta love error messages that make it sound like nothing is actually wrong! 😆

I think the dev console message is unrelated (I've seen it before on main) and I think it is raised before everything is displayed so it doesn't seem to affect anything (but we should dig into that at some point).

Can you track down what traitlet is raising that by any chance? I created a subset and computed the curve of growth in your PR, but failed to reproduce. Is there any other step I'm missing?

[pllim]

Do you see it if you run the example in https://github.com/spacetelescope/jdaviz/blob/main/notebooks/concepts/imviz_simple_aper_phot.ipynb ?

If it is just me, I'll chuck it under "dirty env, too bad" and move on...

[kecnry]

I do see it there, including when creating and using manual subsets, but do not see it in the 47 Tuc data from the example notebook 🤔

[pllim]

imviz_simple_aper_phot.ipynb uses old simulated JWST data. But since you see the warning outside this patch, maybe we can chuck it under "out of scope, worry later"?

[kecnry]

Just checked in main and I do not see the same message there when running "radial profile", and in this PR it also seems to only occur during "curve of growth". So I think it was introduced here... the warning itself seems pretty harmless, but it would be nice to know where it is coming from and suppress it if possible?

[codecov]

Codecov Report

Merging #1287 (1bece52) into main (5656dc5) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1287      +/-   ##
==========================================
+ Coverage   80.96%   81.07%   +0.10%     
==========================================
  Files          90       90              
  Lines        7428     7471      +43     
==========================================
+ Hits         6014     6057      +43     
  Misses       1414     1414              

Impacted Files	Coverage Δ
...imviz/plugins/aper_phot_simple/aper_phot_simple.py	91.46% <100.00%> (+1.46%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5656dc5...1bece52. Read the comment docs.

[kecnry]

LGTM - can't find a way to break it and the warning messages are now gone!

[rosteen]

Looks good to me, didn't manage to break it.