Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename One Color Per Layer to Monochromatic #1406

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jun 20, 2022

Description

This pull request is to rename One Color Per Layer to Monochromatic for image viewers. This is built upon #1343.

Screenshot 2022-06-20 145831

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@pllim pllim added this to the 2.7 milestone Jun 20, 2022
@pllim pllim requested a review from larrybradley June 20, 2022 18:05
@pllim pllim marked this pull request as ready for review June 20, 2022 18:27
Copy link
Member

@larrybradley larrybradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. Can we also change "Colormaps" to "Colormap"?

@pllim
Copy link
Contributor Author

pllim commented Jun 20, 2022

@larrybradley , done. Please approve if you are happy with this.

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #1406 (026a1c3) into main (b3c0a24) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1406   +/-   ##
=======================================
  Coverage   85.11%   85.11%           
=======================================
  Files          91       91           
  Lines        8308     8310    +2     
=======================================
+ Hits         7071     7073    +2     
  Misses       1237     1237           
Impacted Files Coverage Δ
jdaviz/core/template_mixin.py 91.35% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3c0a24...026a1c3. Read the comment docs.

Copy link
Member

@larrybradley larrybradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pllim

@pllim
Copy link
Contributor Author

pllim commented Jun 23, 2022

Thanks for the reviews!

@pllim pllim merged commit e267773 into spacetelescope:main Jun 23, 2022
@pllim pllim deleted the monochromatic branch June 23, 2022 17:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants