Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

BUG: Fix HeI-HeII data file #1431

Merged
merged 1 commit into from
Jun 29, 2022
Merged

BUG: Fix HeI-HeII data file #1431

merged 1 commit into from
Jun 29, 2022

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jun 29, 2022

Description

This pull request is to add a missing comma to the CSV data file.

Fixes #1430

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added bug Something isn't working trivial Only needs one approval instead of two labels Jun 29, 2022
@pllim pllim added this to the 2.7 milestone Jun 29, 2022
@pllim pllim requested a review from camipacifici June 29, 2022 16:39
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #1431 (1744617) into main (a1d7d83) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1431      +/-   ##
==========================================
+ Coverage   85.14%   85.15%   +0.01%     
==========================================
  Files          91       91              
  Lines        8325     8331       +6     
==========================================
+ Hits         7088     7094       +6     
  Misses       1237     1237              
Impacted Files Coverage Δ
jdaviz/app.py 92.86% <0.00%> (ø)
jdaviz/core/template_mixin.py 91.42% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1d7d83...1744617. Read the comment docs.

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple enough, thanks!

@kecnry kecnry merged commit ff6e668 into spacetelescope:main Jun 29, 2022
@pllim pllim deleted the fix-hei-heii branch June 29, 2022 17:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cubeviz: traceback when loading HeI-HeII line list
2 participants