Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

mosviz gaussian smooth: only include data from spectrum-viewer #1452

Merged

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jul 5, 2022

Description

This pull request limits the data dropdown in the gaussian smooth plugin in mosviz to only include data entries in the (1d) spectrum-viewer.

Fixes #1451

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 2.7 milestone Jul 5, 2022
@kecnry kecnry force-pushed the mosviz-gaussian-smooth-only-spec1d branch from 68b8c40 to 132bf11 Compare July 5, 2022 18:38
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #1452 (132bf11) into main (050b62d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1452   +/-   ##
=======================================
  Coverage   85.16%   85.17%           
=======================================
  Files          91       91           
  Lines        8359     8362    +3     
=======================================
+ Hits         7119     7122    +3     
  Misses       1240     1240           
Impacted Files Coverage Δ
...default/plugins/gaussian_smooth/gaussian_smooth.py 96.20% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 050b62d...132bf11. Read the comment docs.

@kecnry kecnry marked this pull request as ready for review July 5, 2022 19:05
@pllim pllim added bug Something isn't working mosviz labels Jul 5, 2022
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised though now that I am looking at this plugin in Mosviz, I noticed something else that are out of scope but need new tickets for if there aren't already.

  1. The data dropdown has extra blank line; not sure why.

Screenshot 2022-07-05 164759

  1. The smoothed spectrum does not appear. I cannot tell if because the smoothed data is to hard to see or the linking is wrong. If the latter, maybe it needs a fix similar to Fix plugin linking in mosviz #1450 that @javerbukh has for model fitting.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, although I had some minor performance issues. Seems like they're also present in main though.

@rosteen rosteen merged commit d337638 into spacetelescope:main Jul 6, 2022
@kecnry kecnry deleted the mosviz-gaussian-smooth-only-spec1d branch July 6, 2022 15:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gaussian smooth does not work in mosviz
3 participants