-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Aperture photometry table (with popout support) #1985
Conversation
5ae0876
to
81bdb46
Compare
Codecov ReportBase: 92.04% // Head: 92.04% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1985 +/- ##
==========================================
- Coverage 92.04% 92.04% -0.01%
==========================================
Files 140 140
Lines 15148 15206 +58
==========================================
+ Hits 13943 13996 +53
- Misses 1205 1210 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API doc could use some text:
- https://jdaviz--1985.org.readthedocs.build/en/1985/api/jdaviz.core.template_mixin.TableMixin.html#jdaviz.core.template_mixin.TableMixin
- https://jdaviz--1985.org.readthedocs.build/en/1985/api/jdaviz.core.template_mixin.Table.html#jdaviz.core.template_mixin.Table
When I "clear all" and select the columns out of order (e.g., "sum" first and then "xcenter"), the display is actually the order that I click, not the actual order in the table. Is that intentional?
Is it intentional that the timestamp is never an option for the UI?
Other than the minor comments, this LGTM. The fact that none of the tests changed give me some relieve that this is mainly UI cosmetics and does not affect backend code. My approval is probably not as important as those from PO or Jenn.
Yes
Somewhat - we can discuss whether to display timestamp and/or a counter for sorting. We'll probably also want to discuss what precision to display in the table UI. Whether those happen within this review or as follow up efforts is up to the reviewers, I suppose. |
7622323
to
58d64a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement. Thanks!
* and rename add_row to add_item
58d64a0
to
46ce7a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice work!
Description
This pull request implements a user-clearable table which displays the history of results from the aperture photometry plugin. The previous
imviz.get_aperture_photometry_results
still works, but now serves as a shortcut toplugin.export_table()
(once the user API is enabled for the aperture photometry plugin).Future planned work includes the ability to display the table in a panel in the golden-layout section of the main app (below all other viewers), but for now support for popping out into a new window exists.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.